netdev - Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support Nokia Slim Modems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201009292121.18274.remi.denis-courmont@nokia.com>
Date:	Wed, 29 Sep 2010 21:21:17 +0300
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	ext Kumar SANGHVI <kumar.sanghvi@...ricsson.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:	"STEricsson_nomadik_linux" <STEricsson_nomadik_linux@...t.st.com>,
	Sudeep DIVAKARAN <sudeep.divakaran@...ricsson.com>,
	Gulshan KARMANI <gulshan.karmani@...ricsson.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>
Subject: Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support Nokia Slim Modems


	Hello,

On Wednesday 29 September 2010 09:32:20 ext Kumar SANGHVI, you wrote:
> We can introduce corrections in Phonet stack for the PS path which
> would be minor. But then those changes look more like a hack. Further,
> this change would be required at several places where PS communication
> is happening with modem e.g. pep_reply, pipe_skb_send, pipe_snd_status,
> etc.
> 
> Further, if a new function tomorrow is introduced for PS path
> communication with modem then, that hack will have to be added to that
> function also.

It seems to me that you really want to implement the connect() socket call, so 
that one of the two endpoints will stand up for the missing controller. That's 
still much cleaner than CREATE and DESTROY ioctl()'s.

Besides, the pipe should be destroyed when the last socket descriptor is 
closed anyway. So ioctl(DESTROY) really seems like a bad idea to me.

Similarly, ENABLE and DISABLE should be revectored into a boolean socket 
option.

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html