netdev - Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support Nokia Slim Modems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100930071952.GA21859@bnru01.bnr.st.com>
Date:	Thu, 30 Sep 2010 12:49:53 +0530
From:	Kumar SANGHVI <kumar.sanghvi@...ricsson.com>
To:	Rémi Denis-Courmont 
	<remi.denis-courmont@...ia.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>,
	Sudeep DIVAKARAN <sudeep.divakaran@...ricsson.com>,
	Gulshan KARMANI <gulshan.karmani@...ricsson.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>
Subject: Re: [PATCH v2 1/2] Phonet: Implement Pipe Controller to support
 Nokia Slim Modems

Hi Rémi Denis-Courmont, 

On Wed, Sep 29, 2010 at 20:21:17 +0200, Rémi Denis-Courmont wrote:
> It seems to me that you really want to implement the connect() socket call, so 
> that one of the two endpoints will stand up for the missing controller.

Yes, implementing connect() socket call would be nice.

> That's 
> still much cleaner than CREATE and DESTROY ioctl()'s.

I have not introduced any new ioctl()'s as part of Pipe controller
implementation.
The PIPE_CREATE/PIPE_DESTROY/PIPE_ENABLE/PIPE_DISABLE are all provided
as socket options.
So, user-space can call setsockopt for creating/enabling or
disabling/destroying pipe.

Regarding implementing connect() socket call, few queries:
1. It should carry out all the same steps which I am currently doing as part
   of PIPE_CREATE socket option, right?
2. Currently, as part of Pipe controller implementation, user-space
   follows below sequence:-
	socket()
	bind()
	listen()
	setsockopt(PIPE_CREATE)
	accept()

   In the phonet stack pipe controller logic, we wait for PEP_CONNECT_RESP
   from host-pep (GPRS socket or video telephony socket is a host-pep.
   pep_reply sends out the PEP_CONNECT_RESP) and remote-pep (modem),
   negotiate the best flow-control to be used, and then send
   PIPE_CREATED_IND, with selected flow-control to both pipe end-points.

   I am not sure how the sequence would be when using the connect() socket
   call.

Thanks for your inputs.

Thanks & regards,
Kumar.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html