lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTinbYu9cY9+=Z4MQU69mm+QsozbWsPp6YZOft_Cb@mail.gmail.com> Date: Tue, 5 Oct 2010 22:49:39 -0700 From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Jesper Dangaard Brouer <hawk@...u.dk>, Alexander Duyck <alexander.h.duyck@...el.com>, Jesper Dangaard Brouer <hawk@...x.dk>, "David S. Miller" <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Carolyn Wyborny <carolyn.wyborny@...el.com> Subject: Re: [PATCH net-next] igb: fix stats handling On Tue, Oct 5, 2010 at 21:36, Eric Dumazet <eric.dumazet@...il.com> wrote: > Le mercredi 06 octobre 2010 à 05:28 +0200, Eric Dumazet a écrit : > >> I'll let Intel guys doing the backporting work, but for old kernels, >> you'll probably need to use "unsigned long" instead of "u64" >> >> My plan is : >> >> - Provide 64bit counters even on 32bit arch >> - with proper synchro (include/linux/u64_stats_sync.h) >> - Add a spinlock so we can apply Jesper patch. > > Here is the net-next-2.6 patch, I am currently enable to test it, the > dev machine with IGB NIC cannot be restarted until tomorrow, my son > Nicolas is currently using it ;) > > Could you and/or Jesper test it, possibly on 32 and 64 bit kernels ? > > Thanks ! > > [PATCH net-next] igb: fix stats handling > > There are currently some problems with igb. > > - On 32bit arches, maintaining 64bit counters without proper > synchronization between writers and readers. > > - Stats updated every two seconds, as reported by Jesper. > (Jesper provided a patch for this) > > - Potential problem between worker thread and ethtool -S > > This patch uses u64_stats_sync, and convert everything to be 64bit safe, > SMP safe, even on 32bit arches. > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> > --- > drivers/net/igb/igb.h | 7 +- > drivers/net/igb/igb_ethtool.c | 10 +- > drivers/net/igb/igb_main.c | 111 +++++++++++++++++++++++--------- > 3 files changed, 94 insertions(+), 34 deletions(-) > Thanks again Eric! I will add your patch to my queue. -- Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists