netdev - Re: [PATCH net-next] igb: fix stats handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1286365002.5138.7.camel@firesoul.comx.local>
Date:	Wed, 06 Oct 2010 13:36:42 +0200
From:	Jesper Dangaard Brouer <hawk@...x.dk>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jesper Dangaard Brouer <hawk@...u.dk>,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>
Subject: Re: [PATCH net-next] igb: fix stats handling

On Wed, 2010-10-06 at 06:36 +0200, Eric Dumazet wrote:
> Le mercredi 06 octobre 2010 à 05:28 +0200, Eric Dumazet a écrit :
> 
> > I'll let Intel guys doing the backporting work, but for old kernels,
> > you'll probably need to use "unsigned long" instead of "u64"
> > 
> > My plan is :
> > 
> > - Provide 64bit counters even on 32bit arch
> > - with proper synchro (include/linux/u64_stats_sync.h)
> > - Add a spinlock so we can apply Jesper patch.

You have already integrated my patch, so you get my:

Acked-by: Jesper Dangaard Brouer <hawk@...x.dk>

> Here is the net-next-2.6 patch, I am currently enable to test it, the
> dev machine with IGB NIC cannot be restarted until tomorrow, my son
> Nicolas is currently using it ;)
> 
> Could you and/or Jesper test it, possibly on 32 and 64 bit kernels ?

I could not resist, I have tested the patch, on a 64 bit kernel, it
works :-).  Did some simple test with two while loops running ethtool -S
and ifconfig, didn't see any wrong packet counts.

Tested-by: Jesper Dangaard Brouer <hawk@...x.dk>

Now back to moving office ;-)

-- 
Med venlig hilsen / Best regards
  Jesper Brouer
  ComX Networks A/S
  Linux Network Kernel Developer
  Cand. Scient Datalog / MSc.CS
  Author of http://adsl-optimizer.dk
  LinkedIn: http://www.linkedin.com/in/brouer


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html