lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4CAC3D94.9010408@grandegger.com> Date: Wed, 06 Oct 2010 11:12:52 +0200 From: Wolfgang Grandegger <wg@...ndegger.com> To: David Miller <davem@...emloft.net> CC: masa-korg@....okisemi.com, andrew.chih.howe.khor@...el.com, sameo@...ux.intel.com, margie.foster@...el.com, netdev@...r.kernel.org, yong.y.wang@...el.com, linux-kernel@...r.kernel.org, socketcan-core@...ts.berlios.de, mkl@...gutronix.de, chripell@...e.org, morinaga526@....okisemi.com, meego-dev@...go.com, kok.howg.ewe@...el.com, joel.clark@...el.com, qi.wang@...el.com Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35 On 10/06/2010 05:09 AM, David Miller wrote: > From: "Masayuki Ohtake" <masa-korg@....okisemi.com> > Date: Wed, 6 Oct 2010 12:07:15 +0900 > >> Does your mail mean, for accepting upstream, NAPI is essential for >> CAN driver ? > > It is up to the CAN maintainers :-) Well, our SJA1000 reference driver does still not use NAPI. But NAPI is for CAN especially useful to avoid the infamous *bus error irq flooding*, which may hang low end systems if the interrupts are handled in the IRQ context. Ohtake, if your system can handle well such CAN bus error irq storms at 1MB/s, then NAPI is *not* a must to have. Anyway, as you are at it, I also suggest to use NAPI right from the beginning. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists