netdev - Re: [PATCH] iwlwifi: fix iwlwifi scanning corner cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101006090228.GA2523@redhat.com>
Date:	Wed, 6 Oct 2010 11:02:35 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Florian Mickler <florian@...kler.org>
Cc:	linville@...driver.com, stable@...nel.org,
	linux-wireless@...r.kernel.org, wey-yi.w.guy@...el.com,
	reinette.chatre@...el.com, ilw@...ux.intel.com,
	johannes.berg@...el.com, ben.m.cahill@...el.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: fix iwlwifi scanning corner cases

Hi Florian

On Wed, Oct 06, 2010 at 12:21:32AM +0200, Florian Mickler wrote:
> Stanislaw Gruszka pointed out, that commit
> "iwl3945: queue the right work if the scan needs to be aborted"
> has an awkward definition of "right". Specifically the abort_scan work
> doesn't notify the generic wireless stack that the scan was aborted.
> 
> In order to get rid of the warning in bug
> https://bugzilla.kernel.org/show_bug.cgi?id=17722
> we inform ieee80211_scan_completed that we are aborting
> the scan by setting the apropriate status bit in request_scan and 
> pass it into ieee80211_scan_completed. 
> 
> Signed-off-by: Florian Mickler <florian@...kler.org>
> ---
> 
> Hi John!
> 
> Here is the fix that Stanislaw described. 
> (Yes, it is in a brown paper bag.)  Please wait for him to review this. 
> 
> Another option would be to just revert my previous patch and live with the 
> warning until the scanning rework hit's mainline.

This patch is not so bad, but better would be just return value from 
{iwlagn,iwl3945}_request_scan instead of queuing anything. I will
prepare patch(s) today or tomorrow.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html