netdev - Re: [PATCH net-next 4/8] tg3: Add EEE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101015181904.GA1389@mcarlson.broadcom.com>
Date:	Fri, 15 Oct 2010 11:19:04 -0700
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
cc:	"Matthew Carlson" <mcarlson@...adcom.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andy@...yhouse.net" <andy@...yhouse.net>
Subject: Re: [PATCH net-next 4/8] tg3: Add EEE support

On Fri, Oct 15, 2010 at 07:17:26AM -0700, Ben Hutchings wrote:
> On Thu, 2010-10-14 at 13:37 -0700, Matt Carlson wrote:
> > This patch adds Energy Efficient Ethernet (EEE) support for the 5718
> > device ID and the 57765 B0 asic revision.
> [...]
> > +/* Clause 45 expansion registers */
> > +#define TG3_CL45_D7_EEEADV_CAP		0x003c
> > +#define TG3_CL45_D7_EEEADV_CAP_100TX	0x0002
> > +#define TG3_CL45_D7_EEEADV_CAP_1000T	0x0004
> 
> I assume this is going to be a standard register, so I think it should
> be defined in <linux/mdio.h>.

O.K.  I'll make the change and respin this patch.

> > +#define TG3_CL45_D7_EEERES_STAT                0x803e
> > +#define TG3_CL45_D7_EEERES_STAT_LP_100TX	0x0002
> > +#define TG3_CL45_D7_EEERES_STAT_LP_1000T	0x0004
> 
> 0x803e not 0x003e?

I'm checking on this one.  EEE works with this patch in place.  Maybe I
can make this a definition that takes a standard clause 45 register as
an input though.

> Also Dave suggested there should be an ethtool interface to control EEE
> <http://thread.gmane.org/gmane.linux.network/164141/focus=165143>.

I don't see any ETH_FLAG definition for this in ethtool.h yet.  Is this
the way everyone wanted to go?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html