| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1287152246.2267.14.camel@achroite.uk.solarflarecom.com> Date: Fri, 15 Oct 2010 15:17:26 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Matt Carlson <mcarlson@...adcom.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, andy@...yhouse.net Subject: Re: [PATCH net-next 4/8] tg3: Add EEE support On Thu, 2010-10-14 at 13:37 -0700, Matt Carlson wrote: > This patch adds Energy Efficient Ethernet (EEE) support for the 5718 > device ID and the 57765 B0 asic revision. [...] > +/* Clause 45 expansion registers */ > +#define TG3_CL45_D7_EEEADV_CAP 0x003c > +#define TG3_CL45_D7_EEEADV_CAP_100TX 0x0002 > +#define TG3_CL45_D7_EEEADV_CAP_1000T 0x0004 I assume this is going to be a standard register, so I think it should be defined in <linux/mdio.h>. > +#define TG3_CL45_D7_EEERES_STAT 0x803e > +#define TG3_CL45_D7_EEERES_STAT_LP_100TX 0x0002 > +#define TG3_CL45_D7_EEERES_STAT_LP_1000T 0x0004 0x803e not 0x003e? Also Dave suggested there should be an ethtool interface to control EEE <http://thread.gmane.org/gmane.linux.network/164141/focus=165143>. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists