lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4CBE9FA0.6010900@redhat.com> Date: Wed, 20 Oct 2010 15:52:00 +0800 From: Cong Wang <amwang@...hat.com> To: nhorman@...driver.com CC: netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net, fubar@...ibm.com, davem@...emloft.net, andy@...yhouse.net Subject: Re: [PATCH 2/2] Revert napi_poll fix for bonding driver On 10/20/10 01:04, nhorman@...driver.com wrote: > From: Neil Horman<nhorman@...driver.com> > > In an erlier patch I modified napi_poll so that devices with IFF_MASTER polled > the per_cpu list instead of the device list for napi. I did this because the > bonding driver has no napi instances to poll, it instead expects to check the > slave devices napi instances, which napi_poll was unaware of. Looking at this > more closely however, I now see this isn't strictly needed. As the bond driver > poll_controller calls the slaves poll_controller via netpoll_poll_dev, which > recursively calls poll_napi on each slave, allowing those napi instances to get > serviced. The earlier patch isn't at all harmfull, its just not needed, so lets > revert it to make the code cleaner. Sorry for the noise, > > Signed-off-by: Neil Horman<nhorman@...driver.com> Looks reasonable to me, Reviewed-by: WANG Cong <amwang@...hat.com> Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists