netdev - RE: [PATCH 3/3] vmxnet3: fix typo setting confPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89E2752CFA8EC044846EB8499819134102BF28D66D@EXCH-MBX-4.vmware.com>
Date:	Fri, 22 Oct 2010 10:46:46 -0700
From:	Shreyas Bhatewara <sbhatewara@...are.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"shemminger@...tta.com" <shemminger@...tta.com>
Subject: RE: [PATCH 3/3] vmxnet3: fix typo setting confPA

> -----Original Message-----
> From: Harvey Harrison [mailto:harvey.harrison@...il.com]
> Sent: Friday, October 22, 2010 10:40 AM
> To: Shreyas Bhatewara
> Cc: netdev@...r.kernel.org; shemminger@...tta.com
> Subject: Re: [PATCH 3/3] vmxnet3: fix typo setting confPA
> 
> On Fri, Oct 22, 2010 at 10:31 AM, Shreyas Bhatewara
> <sbhatewara@...are.com> wrote:
> > On Thu, 21 Oct 2010, Harvey Harrison wrote:
> >
> >> It's a le64, not a le32, typo in one place only.
> >>
> >
> > Sure it is. Thanks for the change.
> >
> > Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>
> >
> >
> 
> One question I had when looking into this, why are you doing
> byteswapping in the VMXNET_{READ,WRITE}_BAR{0,1}
> macros?

Because values need to be written in LE orders in registers. For eg. when rx_ring.next2fill index is written to RXPROD reg, it should be converted from CPU order to LE.

->Shreyas


> 
> Harvey