netdev - Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101025.115613.71111117.davem@davemloft.net>
Date:	Mon, 25 Oct 2010 11:56:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	therbert@...gle.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH 1/2 v3] xps: Improvements in TX queue selection

From: Tom Herbert <therbert@...gle.com>
Date: Mon, 25 Oct 2010 10:02:05 -0700

> Would this be sufficient:
> 
> @@ -825,7 +825,8 @@ static int tcp_transmit_skb(struct sock *sk,
> struct sk_buff *skb
>         if (tcp_packets_in_flight(tp) == 0) {
>                 tcp_ca_event(sk, CA_EVENT_TX_START);
>                 skb->ooo_okay = 1;
> -       }
> +       } else
> +               skb->ooo_okay = 0;

Or, alternatively, you could clear it at the point it's tested in
the device transmit path.

This might make the changes for SCTP and other protocols much
easier.

For now, either way is fine with me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html