netdev - Re: [PATCH] net: reset gso header when the copied skb is linearized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101026.113157.233700961.davem@davemloft.net>
Date:	Tue, 26 Oct 2010 11:31:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fleitner@...hat.com
Cc:	netdev@...r.kernel.org, herbert@...dor.apana.org.au
Subject: Re: [PATCH] net: reset gso header when the copied skb is linearized

From: Flavio Leitner <fleitner@...hat.com>
Date: Mon, 25 Oct 2010 20:23:18 -0200

> The gso header is incorrect when the copied skb is
> linearized. This patch creates another helper function
> to copy the gso header when it is appropriated
> 
> Signed-off-by: Flavio Leitner <fleitner@...hat.com>

I don't understand why the GSO information should be
omitted just because we are creating a linearlized
version of the SKB?

The packet still could have a larger than MSS size,
and thus be composed of multiple actual segments for
the network.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html