netdev - Re: [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR writing macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Oct 2010 11:17:31 -0700 (PDT)
From:	Shreyas Bhatewara <sbhatewara@...are.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	pv-drivers@...are.com
Subject: Re: [PATCH 1/2] vmxnet3: remove unnecessary byteswapping in BAR
 writing macros

Harvey,
Thanks for working on this. The change looks good.

Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>


On Wed, 27 Oct 2010, Harvey Harrison wrote:

> readl/writel swap to little-endian internally.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_int.h |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_int.h b/drivers/net/vmxnet3/vmxnet3_int.h
> index 8a2f471..edf2288 100644
> --- a/drivers/net/vmxnet3/vmxnet3_int.h
> +++ b/drivers/net/vmxnet3/vmxnet3_int.h
> @@ -330,14 +330,14 @@ struct vmxnet3_adapter {
>  };
>  
>  #define VMXNET3_WRITE_BAR0_REG(adapter, reg, val)  \
> -	writel(cpu_to_le32(val), (adapter)->hw_addr0 + (reg))
> +	writel((val), (adapter)->hw_addr0 + (reg))
>  #define VMXNET3_READ_BAR0_REG(adapter, reg)        \
> -	le32_to_cpu(readl((adapter)->hw_addr0 + (reg)))
> +	readl((adapter)->hw_addr0 + (reg))
>  
>  #define VMXNET3_WRITE_BAR1_REG(adapter, reg, val)  \
> -	writel(cpu_to_le32(val), (adapter)->hw_addr1 + (reg))
> +	writel((val), (adapter)->hw_addr1 + (reg))
>  #define VMXNET3_READ_BAR1_REG(adapter, reg)        \
> -	le32_to_cpu(readl((adapter)->hw_addr1 + (reg)))
> +	readl((adapter)->hw_addr1 + (reg))
>  
>  #define VMXNET3_WAKE_QUEUE_THRESHOLD(tq)  (5)
>  #define VMXNET3_RX_ALLOC_THRESHOLD(rq, ring_idx, adapter) \
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html