netdev - Re: [PATCH 2/2] vmxnet: trivial annotation of protocol constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.1010291119270.8381@sbhatewara-dev1.eng.vmware.com>
Date:	Fri, 29 Oct 2010 11:20:10 -0700 (PDT)
From:	Shreyas Bhatewara <sbhatewara@...are.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	pv-drivers@...are.com
Subject: Re: [PATCH 2/2] vmxnet: trivial annotation of protocol constant


Thanks.

Signed-off-by: Shreyas Bhatewara <sbhatewara@...are.com>


On Wed, 27 Oct 2010, Harvey Harrison wrote:

> Noticed by sparse:
> drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
> drivers/net/vmxnet3/vmxnet3_drv.c:876:38: warning: cast from restricted __be16
> drivers/net/vmxnet3/vmxnet3_drv.c:876:24: warning: restricted __be16 degrades to integer
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index e3658e1..21314e0 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -873,7 +873,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct vmxnet3_tx_queue *tq,
>  	count = VMXNET3_TXD_NEEDED(skb_headlen(skb)) +
>  		skb_shinfo(skb)->nr_frags + 1;
>  
> -	ctx.ipv4 = (skb->protocol == __constant_ntohs(ETH_P_IP));
> +	ctx.ipv4 = (skb->protocol == cpu_to_be16(ETH_P_IP));
>  
>  	ctx.mss = skb_shinfo(skb)->gso_size;
>  	if (ctx.mss) {
> -- 
> 1.7.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html