netdev - Re: [PATCH] jme: fix panic on load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101031.092636.193730282.davem@davemloft.net>
Date:	Sun, 31 Oct 2010 09:26:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cooldavid@...ldavid.org
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] jme: fix panic on load

From: "Guo-Fu Tseng" <cooldavid@...ldavid.org>
Date: Mon, 1 Nov 2010 00:39:14 +0800

> On Sun, 31 Oct 2010 16:46:18 +0100, Eric Dumazet wrote
> Can this patch be modified to move the netif_stop_queue()
> after register_netdev() ?
> It seems the __QUEUE_STATE_XOFF is not set after the register_netdev.
> The tx_queue was kcalloc() ed without touching state flags.

At the veyr moment that register_netdev() is called, the
->open() method of your driver can be invoked and the
queue state changed.

So no, you can't put it after the register call.

There is zero reason to touch the queue state in your
probe routine, the state of the queue before ->open()
is "don't care".

Eric's patch is going to be applied, it is correct.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html