lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 31 Oct 2010 17:32:12 +0100
From:	Eric Dumazet <>
To:	Guo-Fu Tseng <>
Cc:	David Miller <>, netdev <>
Subject: Re: [PATCH] jme: fix panic on load

Le lundi 01 novembre 2010 à 00:39 +0800, Guo-Fu Tseng a écrit :
> Can this patch be modified to move the netif_stop_queue()
> after register_netdev() ?
> It seems the __QUEUE_STATE_XOFF is not set after the register_netdev.
> The tx_queue was kcalloc() ed without touching state flags.

Real question is : why this netif_stop_queue() was needed at the first
place ?

We believe (David and others), that using before ndo_open() is useless
or a sign of design error.

Refs: commit c117e4a2bb4911

If your driver doesnt work after my change, then another patch is
needed, but not using netif_stop_queue() right after register_netdev()

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists