netdev - Re: [PATCH] jme: fix panic on load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288542732.2660.57.camel@edumazet-laptop>
Date:	Sun, 31 Oct 2010 17:32:12 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Guo-Fu Tseng <cooldavid@...ldavid.org>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] jme: fix panic on load

Le lundi 01 novembre 2010 à 00:39 +0800, Guo-Fu Tseng a écrit :
> Can this patch be modified to move the netif_stop_queue()
> after register_netdev() ?
> It seems the __QUEUE_STATE_XOFF is not set after the register_netdev.
> The tx_queue was kcalloc() ed without touching state flags.
> 

Real question is : why this netif_stop_queue() was needed at the first
place ?

We believe (David and others), that using before ndo_open() is useless
or a sign of design error.

http://www.spinics.net/lists/netdev/msg145481.html


Refs: commit c117e4a2bb4911

If your driver doesnt work after my change, then another patch is
needed, but not using netif_stop_queue() right after register_netdev()



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html