netdev - Re: [net-next PATCH 1/2] qlge: Add firmware info to ethtool get regs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101108.134932.116391208.davem@davemloft.net>
Date:	Mon, 08 Nov 2010 13:49:32 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ron.mercer@...gic.com
Cc:	netdev@...r.kernel.org, jitendra.kalsaria@...gic.com,
	ying.lok@...gic.com
Subject: Re: [net-next PATCH 1/2] qlge: Add firmware info to ethtool get
 regs.

From: David Miller <davem@...emloft.net>
Date: Mon, 08 Nov 2010 13:43:02 -0800 (PST)

> From: Ron Mercer <ron.mercer@...gic.com>
> Date: Wed, 27 Oct 2010 07:58:26 -0700
> 
>> By default we add firmware information to ethtool get regs.
>> Optionally firmware info can instead be sent to log.
>> 
>> Signed-off-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
>> Signed-off-by: Ron Mercer <ron.mercer@...gic.com>
> 
> Applied.

Nevermind, reverted, can you please more carefully build test
your changes?

drivers/net/qlge/qlge_mpi.c:90:12: error: static declaration of 'ql_soft_reset_mpi_risc' follows non-static declaration
drivers/net/qlge/qlge.h:2224:5: note: previous declaration of 'ql_soft_reset_mpi_risc' was here

The line that added the extern declaration to qlge.h seems to be completely
unrelated to the rest of the patch, as if it's a mis-commit or something
from another change you were working on.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html