netdev - Re: [net-next PATCH 1/2] qlge: Add firmware info to ethtool get regs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Nov 2010 11:24:30 -0800
From:	Ron Mercer <ron.mercer@...gic.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Ying Ping Lok <ying.lok@...gic.com>
Subject: Re: [net-next PATCH 1/2] qlge: Add firmware info to ethtool get
	regs.

On Mon, Nov 08, 2010 at 01:49:32PM -0800, David Miller wrote:
> 
> Nevermind, reverted, can you please more carefully build test
> your changes?
> 
> drivers/net/qlge/qlge_mpi.c:90:12: error: static declaration of 'ql_soft_reset_mpi_risc' follows non-static declaration
> drivers/net/qlge/qlge.h:2224:5: note: previous declaration of 'ql_soft_reset_mpi_risc' was here
> 
> The line that added the extern declaration to qlge.h seems to be completely
> unrelated to the rest of the patch, as if it's a mis-commit or something
> from another change you were working on.

Dave,  I think another patch (correctly) set this function to static
before ours got applied.  Corrected patch is on it's way.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html