netdev - Re: [PATCH] inet: fix ip_mc_drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101109.082656.193719925.davem@davemloft.net>
Date:	Tue, 09 Nov 2010 08:26:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	markus@...ppelsdorf.de, paulmck@...ux.vnet.ibm.com,
	miles.lane@...il.com, ilpo.jarvinen@...sinki.fi,
	linux-kernel@...r.kernel.org, lenb@...nel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] inet: fix ip_mc_drop_socket()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 08 Nov 2010 22:15:54 +0100

> Hmm, I believe I found the bug.
> 
> Thanks guys !
> 
> [PATCH] inet: fix ip_mc_drop_socket()
> 
> commit 8723e1b4ad9be4444 (inet: RCU changes in inetdev_by_index())
> forgot one call site in ip_mc_drop_socket()
> 
> We should not decrease idev refcount after inetdev_by_index() call,
> since refcount is not increased anymore.
> 
> Reported-by: Markus Trippelsdorf <markus@...ppelsdorf.de>
> Reported-by: Miles Lane <miles.lane@...il.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html