netdev - Re: [PATCH 4/10] Fix leaking of kernel heap addresses in net/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Nov 2010 21:51:04 -0500
From:	Dan Rosenberg <drosenberg@...curity.com>
To:	David Miller <davem@...emloft.net>
Cc:	socketcan@...tkopp.net, kuznet@....inr.ac.ru,
	urs.thuermann@...kswagen.de, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, jmorris@...ei.org, remi.denis-courmont@...ia.com,
	pekkas@...core.fi, sri@...ibm.com, vladislav.yasevich@...com,
	tj@...nel.org, eric.dumazet@...il.com, lizf@...fujitsu.com,
	joe@...ches.com, shemminger@...tta.com, hadi@...atatu.com,
	ebiederm@...ssion.com, adobriyan@...il.com, jpirko@...hat.com,
	johannes.berg@...el.com, daniel.lezcano@...e.fr, xemul@...nvz.org,
	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org, torvalds@...ux-foundation.org
Subject: Re: [PATCH 4/10] Fix leaking of kernel heap addresses in net/


> > 
> >> I want whatever you replace it with to be equivalent for
> >> object tracking purposes.
> > 
> > In nearly all of the cases I fixed, the socket inode is already
> > provided, which serves as a perfectly good unique identifier.  Would you
> > prefer I include that information twice?
> 
> The problem is that the socket inode is not available in a certain
> subclass of cases, so the transformation is not equivalent.
> 
> Why not attack this at the heart of where your concern is, and hack
> the %p format handling to do whatever it is you like instead of
> patching code all over the tree?

This has already been suggested, and I agree it is a much better
approach.  If I take this approach, and find some suitable substitute
for those cases where the socket inode is not available, will you
consider these changes?

-Dan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html