netdev - Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CDCF8C3.6010007@trash.net>
Date:	Fri, 12 Nov 2010 09:20:19 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Ben Greear <greearb@...delatech.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path

On 11.11.2010 08:14, Eric Dumazet wrote:
> macvlan is a stacked device, like tunnels. We should use the lockless
> mechanism we are using in tunnels and loopback.
> 
> This patch completely removes locking in TX path.
> 
> tx stat counters are added into existing percpu stat structure, renamed
> from rx_stats to pcpu_stats.
> 
> Note : this reverts commit 2c11455321f37 (macvlan: add multiqueue
> capability)
> 
> Note : rx_errors converted to a 32bit counter, like tx_dropped, since
> they dont need 64bit range.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: Ben Greear <greearb@...delatech.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>
> ---
> V2: correct kerneldoc
>     u32 for tx_dropped and rx_errors

Looks good to me.

Acked-by: Patrick McHardy <kaber@...sh.net>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html