netdev - Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101116.105931.28828795.davem@davemloft.net>
Date:	Tue, 16 Nov 2010 10:59:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	greearb@...delatech.com, bhutchings@...arflare.com
Subject: Re: [PATCH net-next-2.6 v2] macvlan: lockless tx path

From: Patrick McHardy <kaber@...sh.net>
Date: Fri, 12 Nov 2010 09:20:19 +0100

> On 11.11.2010 08:14, Eric Dumazet wrote:
>> macvlan is a stacked device, like tunnels. We should use the lockless
>> mechanism we are using in tunnels and loopback.
>> 
>> This patch completely removes locking in TX path.
>> 
>> tx stat counters are added into existing percpu stat structure, renamed
>> from rx_stats to pcpu_stats.
>> 
>> Note : this reverts commit 2c11455321f37 (macvlan: add multiqueue
>> capability)
>> 
>> Note : rx_errors converted to a 32bit counter, like tx_dropped, since
>> they dont need 64bit range.
>> 
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> Cc: Patrick McHardy <kaber@...sh.net>
>> Cc: Ben Greear <greearb@...delatech.com>
>> Cc: Ben Hutchings <bhutchings@...arflare.com>
>> ---
>> V2: correct kerneldoc
>>     u32 for tx_dropped and rx_errors
> 
> Looks good to me.
> 
> Acked-by: Patrick McHardy <kaber@...sh.net>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html