netdev - Re: [PATCH] netfilter: place in source hash after SNAT is done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=ymap8-3ZJQ6OOSKNeQ9jrbUr7SwFNH9L3Nv7T@mail.gmail.com>
Date:	Mon, 15 Nov 2010 19:16:46 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] netfilter: place in source hash after SNAT is done

On Mon, Nov 15, 2010 at 7:07 PM, Patrick McHardy <kaber@...sh.net> wrote:
> On 15.11.2010 05:48, Changli Gao wrote:
>> If SNAT isn't done, the wrong info maybe got by the other cts.
>>
>> As the filter table is after DNAT table, the packets dropped in filter
>> table also bother bysource hash table.
>>
>> Signed-off-by: Changli Gao <xiaosuo@...il.com>
>> ---
>>  net/ipv4/netfilter/nf_nat_core.c |   18 +++++++++++-------
>>  1 file changed, 11 insertions(+), 7 deletions(-)
>> diff --git a/net/ipv4/netfilter/nf_nat_core.c b/net/ipv4/netfilter/nf_nat_core.c
>> index c04787c..51ce55a 100644
>> --- a/net/ipv4/netfilter/nf_nat_core.c
>> +++ b/net/ipv4/netfilter/nf_nat_core.c
>> @@ -545,11 +550,10 @@ static void nf_nat_move_storage(void *new, void *old)
>>       struct nf_conn_nat *old_nat = old;
>>       struct nf_conn *ct = old_nat->ct;
>>
>> -     if (!ct || !(ct->status & IPS_NAT_DONE_MASK))
>> +     if (!ct || !(ct->status & IPS_SRC_NAT_DONE))
>>               return;
>>
>>       spin_lock_bh(&nf_nat_lock);
>> -     new_nat->ct = ct;
>
> Why are you removing this?
>

nf_ct_ext uses __krealloc() to enlarge memory, so the content has been
copied already.

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html