netdev - Re: [net-2.6 PATCH] nete zero kobject in rx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CE22F22.4000706@intel.com>
Date:	Mon, 15 Nov 2010 23:13:38 -0800
From:	John Fastabend <john.r.fastabend@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"therbert@...gle.com" <therbert@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
Subject: Re: [net-2.6 PATCH] nete zero kobject in rx_queue_release

On 11/15/2010 6:06 PM, John Fastabend wrote:
> On 11/14/2010 3:15 PM, David Miller wrote:
>> From: Tom Herbert <therbert@...gle.com>
>> Date: Sun, 14 Nov 2010 14:40:00 -0800
>>
>>>> So we'll need something like:
>>>>
>>>>        if (atomic_dec_and_test(&first->count))
>>>>                kfree(first);
>>>>        else
>>>>                /* clear everything except queue->first */
>>>>
>>>
>>> The patches to get rid of the separate refcnt should obviate this
>>> complexity.  Could just clear the queue in kobject release.
>>
>> True but we'll still need a patch for older kernels.
> 
> OK Thanks. I'll have a stable patch and a net-2.6 patch soon.
> 
> -- John

To address Tom's comment, queue->dev would need to be reset if the queue was cleared. In the latest patch I didn't bother and just clear the kobject.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html