netdev - Re: [PATCH net-next-2.6] can: add slcan driver for serial/USB-serial CAN adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101129233718.45dee61d@lxorguk.ukuu.org.uk>
Date:	Mon, 29 Nov 2010 23:37:18 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Oliver Hartkopp <socketcan@...tkopp.net>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	SocketCAN Core Mailing List <socketcan-core@...ts.berlios.de>
Subject: Re: [PATCH net-next-2.6] can: add slcan driver for
 serial/USB-serial CAN adapters

On Mon, 29 Nov 2010 21:30:45 +0100
Oliver Hartkopp <socketcan@...tkopp.net> wrote:

> This patch adds support for serial/USB-serial CAN adapters implementing the
> LAWICEL ASCII protocol for CAN frame transport over serial lines.
> 
> The driver implements the SLCAN line discipline and is heavily based on the
> slip.c driver. Therefore the code style remains similar to slip.c to be able
> to apply changes of the SLIP driver to the SLCAN driver easily.

It looks almost identical. Would it not be better to either extract the
common code or put slip and slcann together as one, otherwise changes
will always get missed as they have to be done twice ?

How hard would it be to make the encap/decap pointers that can be
set to cleanly abstract both ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html