netdev - Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101129233334.GA2888@electric-eye.fr.zoreil.com>
Date:	Tue, 30 Nov 2010 00:33:34 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	hayeswang <hayeswang@...ltek.com>
Cc:	"'Ben Hutchings'" <benh@...ian.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"'David Miller'" <davem@...emloft.net>, 564628@...s.debian.org
Subject: Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

hayeswang <hayeswang@...ltek.com> :
> Excuse me, I have some questions about the firmware patch.
> 
> 1. I should convert the data into the binary files (.bin). Is it right?

You may do it.

Fwiw I have cooked something for it in the attached patch #9 this WE. Feel
free to take bits from it. I will not do more changes while you work on it.

> 2. Where should I update the firmware files? Is the path the
> linux-2.6/firmware?

! This directory is only here to contain firmware images extracted from old
! device drivers which predate the common use of request_firmware().

It is fine for the existing code.

> However, according to linux-2.6/firmeware/README.AddingFirmware, I
> should update they to another repository:
> 	
> git://git.kernel.org/pub/scm/linux/kernel/git/dwmw2/linux-firmware.git

/me scratches head.

Assuming Realtek does not intend to stand this code / data as GPLable, yes.
It will help people staying clear from non-free code, it will help packaging
something useful and it will remove some cruft from the code.

So everybody will end happy. Especially after an aspirin.

-- 
Ueimor

View attachment "0001-Correct-the-binary-code-Low-pass-filter-DLY_CAP-fine.patch" of type "text/plain" (6873 bytes)

View attachment "0002-r8169-identify-different-registers.patch" of type "text/plain" (3244 bytes)

View attachment "0003-r8169-use-device-dependent-methods-to-access-the-MII.patch" of type "text/plain" (24064 bytes)

View attachment "0004-r8169-8168DP-specific-MII-registers-access-methods.patch" of type "text/plain" (3970 bytes)

View attachment "0005-r8169-phy-power-ops.patch" of type "text/plain" (6191 bytes)

View attachment "0006-r8169-rtl_csi_access_enable-rename.patch" of type "text/plain" (3627 bytes)

View attachment "0007-r8169-magic.patch" of type "text/plain" (3549 bytes)

View attachment "0008-r8169-more-8168dp-support.patch" of type "text/plain" (9185 bytes)

View attachment "0009-r8169-firmware-isolation-wip.patch" of type "text/plain" (56907 bytes)