netdev - Re: [PATCH 1/3] net: kill unused macros in head file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291016563.7802.2.camel@takos>
Date:	Mon, 29 Nov 2010 16:42:43 +0900
From:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
To:	Shan Wei <shanwei@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>,
	Network-Maillist <netdev@...r.kernel.org>, kuznet@....inr.ac.ru,
	pekkas@...core.fi, jmorris@...ei.org,
	Patrick McHardy <kaber@...sh.net>, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH 1/3] net: kill unused macros in head file

2010-11-29 14:53 +0800, Shan Wei wrote:
> These macros have been defined for several years since v2.6.12-rc2（tracing by git）,
> but never be used. So remove them.
> 
> 
> Signed-off-by: Shan Wei <shanwei@...fujitsu.com>
> ---
>  include/net/addrconf.h  |    2 --
>  include/net/ip6_route.h |    1 -
>  include/net/ndisc.h     |    6 ------
>  include/net/snmp.h      |    1 -
>  include/net/sock.h      |    3 ---
>  include/net/tcp.h       |    6 ------
>  6 files changed, 0 insertions(+), 19 deletions(-)
> 
> diff --git a/include/net/addrconf.h b/include/net/addrconf.h
> index a944124..23710aa 100644
> --- a/include/net/addrconf.h
> +++ b/include/net/addrconf.h
> @@ -1,8 +1,6 @@
>  #ifndef _ADDRCONF_H
>  #define _ADDRCONF_H
>  
> -#define RETRANS_TIMER	HZ
> -
>  #define MAX_RTR_SOLICITATIONS		3
>  #define RTR_SOLICITATION_INTERVAL	(4*HZ)
>  

I think we should use it in net/ipv6/addrconf.c,
instead of magic number.

> diff --git a/include/net/ndisc.h b/include/net/ndisc.h
> index 895997b..f134987 100644
> --- a/include/net/ndisc.h
> +++ b/include/net/ndisc.h
> @@ -39,12 +39,6 @@ enum {
>  
>  #define MAX_RTR_SOLICITATION_DELAY	HZ
>  
> -#define ND_REACHABLE_TIME		(30*HZ)
> -#define ND_RETRANS_TIMER		HZ

ditto (in net/ipv6/ndisc.c)

--yoshfuji

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html