netdev - Re: [PATCH 1/3] net: kill unused macros in head file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CF3627A.1040401@cn.fujitsu.com>
Date:	Mon, 29 Nov 2010 16:21:14 +0800
From:	Shan Wei <shanwei@...fujitsu.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
CC:	David Miller <davem@...emloft.net>,
	Network-Maillist <netdev@...r.kernel.org>, kuznet@....inr.ac.ru,
	pekkas@...core.fi, jmorris@...ei.org,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH 1/3] net: kill unused macros in head file

Hi yoshifuji-san:

YOSHIFUJI Hideaki wrote, at 11/29/2010 03:42 PM:
>>  
>> -#define RETRANS_TIMER	HZ
>> -
>>  #define MAX_RTR_SOLICITATIONS		3
>>  #define RTR_SOLICITATION_INTERVAL	(4*HZ)
>>  
> 
> I think we should use it in net/ipv6/addrconf.c,
> instead of magic number.

Do you mean to replace all HZ in net/ipv6/addrconf.c with RETRANS_TIMER?

HZ is also a macro. And I think HZ is more easier to read than RETRANS_TIMER.


-- 
Best Regards
-----
Shan Wei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html