netdev - Re: [PATCH 1/3] net: kill unused macros in head file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101201.123300.35042706.davem@davemloft.net>
Date:	Wed, 01 Dec 2010 12:33:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shanwei@...fujitsu.com
Cc:	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	kaber@...sh.net
Subject: Re: [PATCH 1/3] net: kill unused macros in head file

From: Shan Wei <shanwei@...fujitsu.com>
Date: Mon, 29 Nov 2010 16:21:14 +0800

> Hi yoshifuji-san:
> 
> YOSHIFUJI Hideaki wrote, at 11/29/2010 03:42 PM:
>>>  
>>> -#define RETRANS_TIMER	HZ
>>> -
>>>  #define MAX_RTR_SOLICITATIONS		3
>>>  #define RTR_SOLICITATION_INTERVAL	(4*HZ)
>>>  
>> 
>> I think we should use it in net/ipv6/addrconf.c,
>> instead of magic number.
> 
> Do you mean to replace all HZ in net/ipv6/addrconf.c with RETRANS_TIMER?
> 
> HZ is also a macro. And I think HZ is more easier to read than RETRANS_TIMER.

These things currently say "1 * HZ" and "30 * HZ", so I think Hideaki's
request is reasonable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html