netdev - Re: [PATCH v2] add netdev led trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ipzgl9k8.fsf@basil.nowhere.org>
Date:	Mon, 29 Nov 2010 11:15:51 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Eric Cooper <ecc@....edu>
Cc:	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	Richard Purdie <rpurdie@...ys.net>,
	Randy Dunlap <rdunlap@...otime.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] add netdev led trigger

Eric Cooper <ecc@....edu> writes:

> Add a netdev LED trigger for all Blinkenlights lovers...
> Originally taken from https://dev.openwrt.org/ticket/2776
> Slightly updated for 2.6.24 by Mickey Lauer <mickey@...nmoko.org>
> and for 2.6.36 by Eric Cooper <ecc@....edu>

You should really send this to netdev too.

Some comments:

The timer seems power unfriendly -- it will always tick even if nothing 
happens.

Using the device name as an identifier is not reliable, they may 
not be unique.

rwlocks are deprecated.

your store code has a off by one I think, it's possible to put 
not 0 terminated data in the string.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html