netdev - Re: [PATCHv6] net: Add batman-adv meshing protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201012012004.34356.sven.eckelmann@gmx.de>
Date:	Wed, 1 Dec 2010 20:04:33 +0100
From:	Sven Eckelmann <sven.eckelmann@....de>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCHv6] net: Add batman-adv meshing protocol

David Miller wrote:
> From: Sven Eckelmann <sven.eckelmann@....de>
> Date: Wed, 1 Dec 2010 19:54:19 +0100
> 
> > Do you have any more possible duplication you have in your mind right
> > now?
> 
> The hashing code, for the third time.

And I asked in the past about the removal of the hashing stuff without any 
reaction. So, we removed most of it. resize and iterate will be dropped too. 
So, is it a problem to have a hash_find, hash_remove, hash_add? These were 
created to reduce duplicated code and not to create a complete new dynamic 
datastructure (which it isn't... it is just the usual hlist stuff)

thanks,
	Sven

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)