netdev - Re: [PATCHv6] net: Add batman-adv meshing protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101201.111205.28818479.davem@davemloft.net>
Date:	Wed, 01 Dec 2010 11:12:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sven.eckelmann@....de
Cc:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org
Subject: Re: [PATCHv6] net: Add batman-adv meshing protocol

From: Sven Eckelmann <sven.eckelmann@....de>
Date: Wed, 1 Dec 2010 20:04:33 +0100

> David Miller wrote:
>> From: Sven Eckelmann <sven.eckelmann@....de>
>> Date: Wed, 1 Dec 2010 19:54:19 +0100
>> 
>> > Do you have any more possible duplication you have in your mind right
>> > now?
>> 
>> The hashing code, for the third time.
> 
> And I asked in the past about the removal of the hashing stuff without any 
> reaction. So, we removed most of it. resize and iterate will be dropped too. 
> So, is it a problem to have a hash_find, hash_remove, hash_add? These were 
> created to reduce duplicated code and not to create a complete new dynamic 
> datastructure (which it isn't... it is just the usual hlist stuff)

Ok, fair enough.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html