netdev - Re: [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101202104200.GD10221@canuck.infradead.org>
Date:	Thu, 2 Dec 2010 05:42:00 -0500
From:	Thomas Graf <tgraf@...radead.org>
To:	Shan Wei <shanwei@...fujitsu.com>
Cc:	David Miller <davem@...emloft.net>,
	Network-Maillist <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB_MAX value

On Thu, Dec 02, 2010 at 06:35:50PM +0800, Shan Wei wrote:
> Thomas Graf wrote, at 12/02/2010 05:57 PM:
> >>  /* ICMP */
> >>  #define ICMP_MIB_DUMMY	__ICMP_MIB_MAX
> >> -#define ICMP_MIB_MAX	(__ICMP_MIB_MAX + 1)
> >> -
> >> +#define ICMP_MIB_MAX	__ICMP_MIB_MAX
> > 
> > Looks like the +1 is there to account for ICMP_MIB_DUMMY. It is
> > unused though but you have to remove it as well if you want to
> > kill that extra +1.
> 
> I don't know the history about ICMP_MIB_DUMMY before v2.6.12-rc2. 
> But after that, it is abandoned.
> 
> ICMP_MIB_DUMMY is killed in patch:
> ［PATCH v2 4/4] net: kill unused macros from head file

OK, fair enough. Wasn't obvious while reviewing this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html