netdev - Re: [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101202.093804.193716088.davem@davemloft.net>
Date:	Thu, 02 Dec 2010 09:38:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...radead.org
Cc:	shanwei@...fujitsu.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/4] net: snmp: fix the wrong ICMP_MIB_MAX value

From: Thomas Graf <tgraf@...radead.org>
Date: Thu, 2 Dec 2010 04:57:53 -0500

> Looks like the +1 is there to account for ICMP_MIB_DUMMY. It is
> unused though but you have to remove it as well if you want to
> kill that extra +1.

He does in patch #4

ICMP_MIB_DUMMY was used in pre-GIT times, as a throw away ICMP counter
that gets bumped when we have no specific counter that should be
bumped for an ICMP code type.  There was a table, per ICMP code,
that listed the counter to bump amongst other things, and this
dummy value was used in that table.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html