netdev - Re: [PATCH] use total_highpages when calculating lowmem-only allocation sizes (dccp)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4CFE54ED02000078000266AD@vpn.id2.novell.com>
Date:	Tue, 07 Dec 2010 14:38:21 +0000
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<akpm@...ux-foundation.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] use total_highpages when calculating lowmem-only
	 allocation sizes (dccp)

>>> On 06.12.10 at 18:36, David Miller <davem@...emloft.net> wrote:
> From: "Jan Beulich" <JBeulich@...ell.com>
> Date: Mon, 06 Dec 2010 16:42:46 +0000
> 
>> For those (large) table allocations that come only from lowmem, the
>> total amount of memory shouldn't really matter.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> 
> Instead of continually tweaking the bits in these code paths,
> we should be converting them over to using a central routine
> such as alloc_large_system_hash() where the logic is consolidated
> _AND_ the code knows to use vmalloc() and NUMA aware allocations
> when warranted.

Hmm, not sure. For one, alloc_large_system_hash() is (and imo
ought to remain) an __init function. Second, looking at the one
non-modular case (netlink_proto_init()), I don't think using this
function would be the intention here.

Jan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html