netdev - Re: [PATCH] use total_highpages when calculating lowmem-only allocation sizes (dccp)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101207.164951.193734247.davem@davemloft.net>
Date:	Tue, 07 Dec 2010 16:49:51 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	JBeulich@...ell.com
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] use total_highpages when calculating lowmem-only
 allocation sizes (dccp)

From: "Jan Beulich" <JBeulich@...ell.com>
Date: Tue, 07 Dec 2010 14:38:21 +0000

>>>> On 06.12.10 at 18:36, David Miller <davem@...emloft.net> wrote:
>> From: "Jan Beulich" <JBeulich@...ell.com>
>> Date: Mon, 06 Dec 2010 16:42:46 +0000
>> 
>>> For those (large) table allocations that come only from lowmem, the
>>> total amount of memory shouldn't really matter.
>>> 
>>> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
>> 
>> Instead of continually tweaking the bits in these code paths,
>> we should be converting them over to using a central routine
>> such as alloc_large_system_hash() where the logic is consolidated
>> _AND_ the code knows to use vmalloc() and NUMA aware allocations
>> when warranted.
> 
> Hmm, not sure. For one, alloc_large_system_hash() is (and imo
> ought to remain) an __init function. Second, looking at the one
> non-modular case (netlink_proto_init()), I don't think using this
> function would be the intention here.

I think the one and only reason DCCP and friends do not use this
interface is exactly because it's not available to modules.

So much (partially incorrect, as you found) code would be removed
if this common routine were exported and utilized.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html