[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1291857494.2795.1.camel@edumazet-laptop>
Date: Thu, 09 Dec 2010 02:18:14 +0100
From: Eric Dumazet <eric.dumazet@...il.com>
To: Stephen Hemminger <shemminger@...tta.com>
Cc: David Miller <davem@...emloft.net>,
Jarek Poplawski <jarkao2@...il.com>, netdev@...r.kernel.org
Subject: Re: tc: show format ABI changed
Le mercredi 08 décembre 2010 à 14:51 -0800, Stephen Hemminger a écrit :
> Although well intentioned, the following patch should have not
> been applied since it changes the kernel ABI. It broke some scripts
> parsing the output format of tc commands.
>
> Before HTB would report bogus zero values, now it reports
> nothing and that changes the output format. Like the empty
> fields in /proc, I argue we can't play fast and loose with
> netlink responses.
>
> Not a big deal to fix the script in this case, in this case
> so don't revert it.
Thanks.
I really prefer not giving false information to user.
If you change tc, please add an option so that user can ask tc not
invent "zero values"
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists