netdev - Re: [PATCH] xfrm: Fix xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101209.203601.112597520.davem@davemloft.net>
Date:	Thu, 09 Dec 2010 20:36:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	steffen.klassert@...unet.com, thomas.egerer@...unet.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: Fix xfrm_state_migrate leak

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 7 Dec 2010 17:31:57 +0800

> On Tue, Dec 07, 2010 at 10:28:56AM +0100, Steffen Klassert wrote:
>> From: Thomas Egerer <thomas.egerer@...unet.com>
>> 
>> xfrm_state_migrate calls kfree instead of xfrm_state_put to free
>> a failed state. According to git commit 553f9118 this can cause
>> memory leaks.
>> 
>> Signed-off-by: Thomas Egerer <thomas.egerer@...unet.com>
>> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
> Good catch.  Thanks!

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html