[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20101213.095446.71129033.davem@davemloft.net>
Date: Mon, 13 Dec 2010 09:54:46 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: opurdila@...acom.com
Cc: netdev@...r.kernel.org, lucian.grijincu@...il.com,
ddvlad@...edu.org
Subject: Re: [PATCH net-next-2.6] net: add dev_close_many
From: Octavian Purdila <opurdila@...acom.com>
Date: Mon, 13 Dec 2010 16:18:23 +0200
> -static int __dev_close(struct net_device *dev)
> +static int __dev_close_many(struct list_head *head)
> {
> - const struct net_device_ops *ops = dev->netdev_ops;
> + struct net_device *dev;
>
> - ASSERT_RTNL();
> - might_sleep();
> + list_for_each_entry(dev, head, unreg_list) {
> + ASSERT_RTNL();
> + might_sleep();
It doesn't make any sense to put these insertions into this loop since
they are testing top-level invariants that must be provided by the
caller.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists