netdev - Re: [PATCH net-2.6 2/3] bonding: Change active slave quietly when bond is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Dec 2010 21:06:15 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-2.6 2/3] bonding: Change active slave quietly when
 bond is down

On Mon, 2010-12-13 at 12:41 -0800, Jay Vosburgh wrote:
> Ben Hutchings <bhutchings@...arflare.com> wrote:
> 
> >bond_change_active_slave() may be called when a slave is added, even
> >if the bond has not been brought up yet.  It may then attempt to send
> >packets, and further it may use mcast_work which is uninitialised
> >before the bond is brought up.  Add the necessary checks for
> >netif_running(bond->dev).
> 
> 	I wondered if it would be better to instead arrange for
> bond_change_active_slave (and bond_select_active_slave, which calls it)
> to not be called when the bond is down, but that would require quite a
> bit of change to bond_enslave and bond_open.
[...]

Yes, it did seem to me that it would be better to defer all these
actions until bond_open, but I thought that would be too risky at this
stage in the release cycle.  Please do clean this up further in
net-next-2.6.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html