netdev - Re: [PATCH net-2.6 1/3] bonding/vlan: Remove redundant VLAN tag insertion logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=BmmTzK29pQWLhGtROGA+OX72170zN_7VwdrM6@mail.gmail.com>
Date:	Mon, 13 Dec 2010 14:08:02 -0800
From:	Jesse Gross <jesse@...ira.com>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-2.6 1/3] bonding/vlan: Remove redundant VLAN tag
 insertion logic

On Mon, Dec 13, 2010 at 11:58 AM, Jay Vosburgh <fubar@...ibm.com> wrote:
> Ben Hutchings <bhutchings@...arflare.com> wrote:
>
>>A bond may have a mixture of slave devices with and without hardware
>>VLAN tag insertion capability.  Therefore it always claims this
>>capability and performs software VLAN tag insertion if the slave does
>>not.
>>
>>Since commit 7b9c60903714bf0a19d746b228864bad3497284e, this has
>>also been done by dev_hard_start_xmit().  The result is that VLAN-
>>tagged skbs are now double-tagged when transmitted through slave
>>devices without hardware VLAN tag insertion!
>>
>>Remove the now-redundant logic from bond_dev_queue_xmit().
>>
>>Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
>
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Thanks for catching this.  I had this change but it was grouped in
with some other bonding/vlan simplifications that were dependent on
the rest of the drivers being converted.

Reviewed-by: Jesse Gross <jesse@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html