netdev - Re: [PATCH] dev_alloc_name: fix kernel-doc formatting, typos, etc.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101217135355.1f88ffff@nehalam>
Date:	Fri, 17 Dec 2010 13:53:55 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	netdev <netdev@...r.kernel.org>, davem@...emloft.net
Subject: Re: [PATCH] dev_alloc_name: fix kernel-doc formatting, typos, etc.

On Fri, 17 Dec 2010 13:40:46 -0800
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> - *	Passed a format string - eg "lt%d" it will try and find a suitable
> + *	Passed a format string - e.g. "lt%%d", it will try to find a suitable

This is wrong.
The obvious case of:
  alloc_etherdev() ends up calling __dev_alloc_name with "eth%d"
in fact __dev_alloc_name called with "lt%%d" will return -EINVAL

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html