netdev - Re: [PATCH net-next-2.6] ifb: add performance flags to dev->features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikNF8Fr-n7j8EcwAp8zfn0U6EqBjORjn-sEJps8@mail.gmail.com>
Date:	Mon, 20 Dec 2010 22:43:46 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>,
	Jarek Poplawski <jarkao2@...il.com>,
	Paweł Staszewski <pstaszewski@...are.pl>,
	Linux Network Development list <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] ifb: add performance flags to dev->features

On Mon, Dec 20, 2010 at 10:25 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>  drivers/net/ifb.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
> index 124dac4..c761551 100644
> --- a/drivers/net/ifb.c
> +++ b/drivers/net/ifb.c
> @@ -136,6 +136,9 @@ static void ifb_setup(struct net_device *dev)
>        ether_setup(dev);
>        dev->tx_queue_len = TX_Q_LIMIT;
>
> +       dev->features |= NETIF_F_NO_CSUM | NETIF_F_SG |
> +                        NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
> +                        NETIF_F_TSO;
>        dev->flags |= IFF_NOARP;
>        dev->flags &= ~IFF_MULTICAST;
>        dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
>
>
>

I think we can assign these features to vlan_features.

dev->vlan_features |= dev->features.

Although I don't know all the features related to GSO,  I just added
all of them. For pseudo NIC, I think it is safe to do so.

+       dev->features |= NETIF_F_SG | NETIF_F_NO_CSUM | NETIF_F_TSO |
+                        NETIF_F_UFO | NETIF_F_GSO_ROBUST | NETIF_F_TSO_ECN |
+                        NETIF_F_TSO6 | NETIF_F_FSO;

-- 
Regards,
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html