netdev - Re: [PATCH net-next-2.6] ifb: add performance flags to dev->features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101228.135013.39173075.davem@davemloft.net>
Date:	Tue, 28 Dec 2010 13:50:13 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	xiaosuo@...il.com, jarkao2@...il.com, pstaszewski@...are.pl,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] ifb: add performance flags to
 dev->features

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 20 Dec 2010 15:25:20 +0100

> Le lundi 20 décembre 2010 à 22:05 +0800, Changli Gao a écrit :
>> 2010/12/20 Jarek Poplawski <jarkao2@...il.com>:
>> >
>> > IMHO it should, (probably even more, like loopback) but we should
>> > consider mirred can xmit to other than ifb too.
>> >
>> 
>> I also think so. And when making ifb a multiqueue NIC, I tried to add
>> these dev features to ifb. :)
>> 
> 
> This has litle to do with your multiqueue work,
> its more an effect of GRO being more and more deployed.
> 
> I dont see dev->features being changed in one of your previous patches.
> I did dummy case in commit 6d81f41c58c6
> 
> [PATCH net-next-2.6] ifb: add performance flags to dev->features
> 
> IFB can use the full set of features flags (NETIF_F_SG |
> NETIF_F_FRAGLIST | NETIF_F_TSO | NETIF_F_NO_CSUM | NETIF_F_HIGHDMA) to
> avoid unecessary split of some packets (GRO for example)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Changli has suggested that these flags can also be set in
->vlan_features, please address that if you expect me to
apply the change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html