lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20101228.134905.183040321.davem@davemloft.net> Date: Tue, 28 Dec 2010 13:49:05 -0800 (PST) From: David Miller <davem@...emloft.net> To: timo.lindfors@....fi Cc: netdev@...r.kernel.org Subject: Re: [PATCH] ip: reuse ip_summed of first fragment for all subsequent fragments From: Timo Juhani Lindfors <timo.lindfors@....fi> Date: Mon, 20 Dec 2010 12:38:45 +0200 > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > index 439d2a3..c0743ed 100644 > --- a/net/ipv4/ip_output.c > +++ b/net/ipv4/ip_output.c > @@ -1167,7 +1167,7 @@ ssize_t ip_append_page(struct sock *sk, struct page *page, > /* > * Fill in the control structures > */ > - skb->ip_summed = CHECKSUM_NONE; > + skb->ip_summed = skb_prev->ip_summed; > skb->csum = 0; > skb_reserve(skb, hh_len); You can't just assign skb_prev->ip_summed here, if it's CHECKSUM_PARTIAL then things will go completely wrong. This is especially true since we're about to zero out skb->csum. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists