lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20101228.134655.112609314.davem@davemloft.net> Date: Tue, 28 Dec 2010 13:46:55 -0800 (PST) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: jarkao2@...il.com, kaber@...sh.net, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next-2.6] sch_sfq: allow big packets and be fair From: Eric Dumazet <eric.dumazet@...il.com> Date: Tue, 21 Dec 2010 14:04:59 +0100 > Le mardi 21 décembre 2010 à 12:17 +0000, Jarek Poplawski a écrit : > >> Oops! You're right yet ;-) This skipping shouldn't happen with quantum >> bigger than max packet size, so this patch is OK. > > Thanks Jarek, here is a v2 with the scale you suggested. > > [PATCH v2 net-next-2.6] sch_sfq: allow big packets and be fair > > SFQ is currently 'limited' to small packets, because it uses a 15bit > allotment number per flow. Introduce a scale by 8, so that we can handle > full size TSO/GRO packets. > > Use appropriate handling to make sure allot is positive before a new > packet is dequeued, so that fairness is respected. > > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com> > Cc: Jarek Poplawski <jarkao2@...il.com> > Cc: Patrick McHardy <kaber@...sh.net> > --- > v2: Use a scale of 8 as Jarek suggested, instead of 18bit fields Eric this doesn't apply cleanly, since the code in sfq_dump_class_stats() is a bit different in net-next-2.6 Please respin this and resubmit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists