| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 09:09:13 -0800
From: Bhavesh Davda <bhavesh@...are.com>
To: Dan Carpenter <error27@...il.com>,
Shreyas Bhatewara <sbhatewara@...are.com>
CC: "VMware, Inc." <pv-drivers@...are.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [Pv-drivers] [patch -next] vmxnet3: locking problems in xmit
Indeed, indeed. Thanks for catching that and fixing it!
>
> There were several paths that didn't release their locks.
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
Signed-off-by: Bhavesh Davda <bhavesh@...are.com>
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 23154cf..939e546 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -980,7 +980,7 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
> }
> } else {
> tq->stats.drop_hdr_inspect_err++;
> - goto drop_pkt;
> + goto unlock_drop_pkt;
> }
>
> /* fill tx descs related to addr & len */
> @@ -1052,6 +1052,8 @@ vmxnet3_tq_xmit(struct sk_buff *skb, struct
> vmxnet3_tx_queue *tq,
>
> hdr_too_big:
> tq->stats.drop_oversized_hdr++;
> +unlock_drop_pkt:
> + spin_unlock_irqrestore(&tq->tx_lock, flags);
> drop_pkt:
> tq->stats.drop_total++;
> dev_kfree_skb(skb);
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@...are.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists