netdev - Re: [PATCH] ipv4: Flush per-ns routing cache more sanely.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292865233.2800.192.camel@edumazet-laptop>
Date:	Mon, 20 Dec 2010 18:13:53 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ebiederm@...ssion.com, netdev@...r.kernel.org,
	daniel.lezcano@...e.fr
Subject: Re: [PATCH] ipv4: Flush per-ns routing cache more sanely.

Le dimanche 19 décembre 2010 à 21:14 -0800, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Tue, 26 Oct 2010 21:30:22 +0200
> 
> > Le mardi 26 octobre 2010 à 12:20 -0700, David Miller a écrit :
> >> From: ebiederm@...ssion.com (Eric W. Biederman)
> >> Date: Tue, 26 Oct 2010 12:05:39 -0700
> >> 
> >> >> @@ -999,7 +999,7 @@ static int fib_netdev_event(struct notifier_block *this, unsigned long event, vo
> >> >>  		rt_cache_flush(dev_net(dev), 0);
> >> >>  		break;
> >> >>  	case NETDEV_UNREGISTER_BATCH:
> >> >> -		rt_cache_flush_batch();
> >> >> +		rt_cache_flush_batch(dev_net(dev));
> >> > 
> >> > It still has this incorrect conversion in it.
> >> 
> >> Sorry I missed that, what's the exact problem with it?
> > 
> > Because the way _BATCH operation is performed, we call it once...
> > 
> > rollback_registered_many() calls it for the first dev queued in the
> > list.
> > 
> > So it should be net independant.
> 
> Thanks Eric.  I finally got back to fixing this issue and respinning
> the patch.
> 
> Please review, in particular how I handled the RCU bits.
> 
> --------------------
> ipv4: Flush per-ns routing cache more sanely.
> 
> Flush the routing cache only of entries that match the
> network namespace in which the purge event occurred.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>


Seems fine to me, thanks !

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html