netdev - Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101220145844.35c4de44@nehalam>
Date:	Mon, 20 Dec 2010 14:58:44 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	John Fastabend <john.r.fastabend@...el.com>, davem@...emloft.net,
	netdev@...r.kernel.org, hadi@...erus.ca, tgraf@...radead.org,
	eric.dumazet@...il.com, nhorman@...driver.com
Subject: Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based
 QOS

On Mon, 20 Dec 2010 22:48:07 +0000
Ben Hutchings <bhutchings@...arflare.com> wrote:

> > +	u8 num_tc;
> > +	struct netdev_tc_txq tc_to_txq[16];
> > +	u8 prio_tc_map[16];  
> 
> That seems like a fair amount of data to add to every net device,
> considering that users may create e.g. a lot of VLAN devices and they
> won't use this state at all.  Have you considered putting these in a
> structure that is accessed indirectly?

The tc stuff should use indirection and only allocate if needed.

-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html