netdev - Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based QOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292885931.2627.128.camel@edumazet-laptop>
Date:	Mon, 20 Dec 2010 23:58:51 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	John Fastabend <john.r.fastabend@...el.com>, davem@...emloft.net,
	netdev@...r.kernel.org, hadi@...erus.ca, shemminger@...tta.com,
	tgraf@...radead.org, nhorman@...driver.com
Subject: Re: [net-next-2.6 PATCH v2] net: implement mechanism for HW based
 QOS

Le lundi 20 décembre 2010 à 22:48 +0000, Ben Hutchings a écrit :

> That seems like a fair amount of data to add to every net device,
> considering that users may create e.g. a lot of VLAN devices and they
> won't use this state at all.  Have you considered putting these in a
> structure that is accessed indirectly?

Yes, this was like this in previous patch, but I asked John to put it in
netdevice instead, in order to avoid a false sharing and this
indirection.

This adds 64 bytes on a netdevice. Most machines dont have more than 16
netdevices, it seems a reasonable cost. (We removed the ingress bloat
some time ago, so no significant increase anyway)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html